netdev - Re: [PATCH net-next 7/9] taskstats: move specifying netlink policy back to ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a11f68716146d9e1b9d29bda4640bc7a57350244.camel@sipsolutions.net>
Date:   Thu, 01 Oct 2020 22:48:58 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, andrew@...n.ch, jiri@...nulli.us,
        mkubecek@...e.cz, dsahern@...nel.org, pablo@...filter.org,
        bsingharora@...il.com
Subject: Re: [PATCH net-next 7/9] taskstats: move specifying netlink policy
 back to ops


> @@ -44,7 +44,7 @@ static const struct nla_policy taskstats_cmd_get_policy[TASKSTATS_CMD_ATTR_MAX+1
>   * We have to use TASKSTATS_CMD_ATTR_MAX here, it is the maxattr in the family.
>   * Make sure they are always aligned.
> 

Probably worth also removing/updating the comments?

But otherwise,

Reviewed-by: Johannes Berg <johannes@...solutions.net>

and I think that is much better than the hacks I put there at the time,
and also of course better than what it had originally without a per-op
maxattr. :)

johannes