netdev - Re: [net V2 01/15] net/mlx5: Don't allow health work when device is uninitialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201001161558.1a095385@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 1 Oct 2020 16:15:58 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     saeed@...nel.org
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Shay Drory <shayd@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Saeed Mahameed <saeedm@...dia.com>
Subject: Re: [net V2 01/15] net/mlx5: Don't allow health work when device is
 uninitialized

On Thu,  1 Oct 2020 12:52:33 -0700 saeed@...nel.org wrote:
> From: Shay Drory <shayd@...lanox.com>
> 
> On error flow due to failure on driver load, driver can be
> un-initializing while a health work is running in the background,
> health work shouldn't be allowed at this point, as it needs resources to
> be initialized and there is no point to recover on driver load failures.
> 
> Therefore, introducing a new state bit to indicated if device is
> initialized, for health work to check before trying to recover the driver.

Can't you cancel this work? Or make sure it's not scheduled?
IMHO those "INITILIZED" bits are an anti-pattern.

> Fixes: b6e0b6bebe07 ("net/mlx5: Fix fatal error handling during device load")
> Signed-off-by: Shay Drory <shayd@...lanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>

You signed off twice :)

We should teach verify_signoff to catch that..