lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 1 Oct 2020 09:30:16 +0530 From: Calvin Johnson <calvin.johnson@....nxp.com> To: Andrew Lunn <andrew@...n.ch> Cc: Russell King - ARM Linux admin <linux@...linux.org.uk>, Grant Likely <grant.likely@....com>, "Rafael J . Wysocki" <rafael@...nel.org>, Jeremy Linton <jeremy.linton@....com>, Andy Shevchenko <andy.shevchenko@...il.com>, Florian Fainelli <f.fainelli@...il.com>, Cristi Sovaiala <cristian.sovaiala@....com>, Florin Laurentiu Chiculita <florinlaurentiu.chiculita@....com>, Ioana Ciornei <ioana.ciornei@....com>, Madalin Bucur <madalin.bucur@....nxp.com>, Heikki Krogerus <heikki.krogerus@...ux.intel.com>, linux-kernel@...r.kernel.org, linux.cj@...il.com, netdev@...r.kernel.org, linux-acpi@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, Diana Madalina Craciun <diana.craciun@....com>, Laurentiu Tudor <laurentiu.tudor@....com>, "David S. Miller" <davem@...emloft.net>, Heiner Kallweit <hkallweit1@...il.com>, Jakub Kicinski <kuba@...nel.org> Subject: Re: [net-next PATCH v1 3/7] net: phy: Introduce fwnode_get_phy_id() On Wed, Sep 30, 2020 at 08:19:02PM +0200, Andrew Lunn wrote: > On Wed, Sep 30, 2020 at 07:07:25PM +0100, Russell King - ARM Linux admin wrote: > > On Wed, Sep 30, 2020 at 06:34:40PM +0200, Andrew Lunn wrote: > > > > @@ -2866,7 +2888,15 @@ EXPORT_SYMBOL_GPL(device_phy_find_device); > > > > */ > > > > struct fwnode_handle *fwnode_get_phy_node(struct fwnode_handle *fwnode) > > > > { > > > > - return fwnode_find_reference(fwnode, "phy-handle", 0); > > > > + struct fwnode_handle *phy_node; > > > > + > > > > + phy_node = fwnode_find_reference(fwnode, "phy-handle", 0); > > > > + if (is_acpi_node(fwnode) || !IS_ERR(phy_node)) > > > > + return phy_node; > > > > + phy_node = fwnode_find_reference(fwnode, "phy", 0); > > > > + if (IS_ERR(phy_node)) > > > > + phy_node = fwnode_find_reference(fwnode, "phy-device", 0); > > > > + return phy_node; > > > > > > Why do you have three different ways to reference a PHY? > > > > Compatibility with the DT version - note that "phy" and "phy-device" > > are only used for non-ACPI fwnodes. This should allow us to convert > > drivers where necessary without fear of causing DT regressions. > > Ah. > > A comment would be good here. Sure. Will add comment. Thanks Calvin
Powered by blists - more mailing lists