lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 1 Oct 2020 09:17:01 +0200 From: Jiri Pirko <jiri@...nulli.us> To: Jacob Keller <jacob.e.keller@...el.com> Cc: netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>, Shannon Nelson <snelson@...sando.io> Subject: Re: [iproute2-next v2 1/1] devlink: display elapsed time during flash update Thu, Oct 01, 2020 at 01:40:12AM CEST, jacob.e.keller@...el.com wrote: >For some devices, updating the flash can take significant time during >operations where no status can meaningfully be reported. This can be >somewhat confusing to a user who sees devlink appear to hang on the >terminal waiting for the device to update. > >Recent changes to the kernel interface allow such long running commands >to provide a timeout value indicating some upper bound on how long the >relevant action could take. > >Provide a ticking counter of the time elapsed since the previous status >message in order to make it clear that the program is not simply stuck. > >Display this message whenever the status message from the kernel >indicates a timeout value. Additionally also display the message if >we've received no status for more than couple of seconds. If we elapse >more than the timeout provided by the status message, replace the >timeout display with "timeout reached". > >Signed-off-by: Jacob Keller <jacob.e.keller@...el.com> Looks nice. Thanks! Reviewed-by: Jiri Pirko <jiri@...dia.com>
Powered by blists - more mailing lists