netdev - Re: [PATCH net-next v2 00/10] genetlink: support per-command policy dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a69c92aac65c718b1bd80c8dc0cbb471cdd17d9b.camel@sipsolutions.net>
Date:   Fri, 02 Oct 2020 17:04:11 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, andrew@...n.ch,
        jiri@...nulli.us, mkubecek@...e.cz, dsahern@...nel.org,
        pablo@...filter.org
Subject: Re: [PATCH net-next v2 00/10] genetlink: support per-command policy
 dump

On Fri, 2020-10-02 at 08:03 -0700, Jakub Kicinski wrote:

> > Huh, I even CC'ed you I think?
> 
> I filter stuff which is to:netdev cc:me and get to it when I read the
> ML. There's too much of it.

Ah, ok :)

> > Yeah, that'd work. I'd probably wonder if we shouldn't do
> > 
> > [OP_POLICY]
> >   [OP] -> (u32, u32)
> > 
> > in a struct with two u32's, since that's quite a bit more compact.
> 
> What do we do if the op doesn't have a dump or do callback?
> 0 is a valid policy ID, sadly :(

Hm, good point. We could do -1 since that can't ever be reached though.

But compactness isn't really that necessary here anyway, so ...

johannes