netdev - Re: [PATCH net-next] dt-bindings: net: dsa: b53: Add missing reg property to example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 2 Oct 2020 08:12:32 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Kurt Kanzenbach <kurt@...utronix.de>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Rob Herring <robh+dt@...nel.org>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] dt-bindings: net: dsa: b53: Add missing reg
 property to example



On 10/1/2020 11:20 PM, Kurt Kanzenbach wrote:
> The switch has a certain MDIO address and this needs to be specified using the
> reg property. Add it to the example.
> 
> Signed-off-by: Kurt Kanzenbach <kurt@...utronix.de>
> ---
>   Documentation/devicetree/bindings/net/dsa/b53.txt | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/dsa/b53.txt b/Documentation/devicetree/bindings/net/dsa/b53.txt
> index cfd1afdc6e94..80437b2fc935 100644
> --- a/Documentation/devicetree/bindings/net/dsa/b53.txt
> +++ b/Documentation/devicetree/bindings/net/dsa/b53.txt
> @@ -106,6 +106,7 @@ Ethernet switch connected via MDIO to the host, CPU port wired to eth0:
>   
>   		switch0: ethernet-switch@30 {

This should actually be 1e because the unit address is supposed to be in 
hexadecimal.

>   			compatible = "brcm,bcm53125";
> +			reg = <30>;

however this one is correct, if you want to resend with the unit address 
fixed that would be fine, if not:

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian