netdev - Re: [RESEND net-next 2/9] arm64: dts: ls1088ardb: add QSGMII PHY nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201002154846.6rfkgrcl24hbal5c@skbuf>
Date:   Fri, 2 Oct 2020 15:48:47 +0000
From:   Ioana Ciornei <ioana.ciornei@....com>
To:     Florian Fainelli <f.fainelli@...il.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [RESEND net-next 2/9] arm64: dts: ls1088ardb: add QSGMII PHY
 nodes

On Fri, Oct 02, 2020 at 08:37:03AM -0700, Florian Fainelli wrote:
> 
> 
> On 10/2/2020 7:48 AM, Ioana Ciornei wrote:
> > Annotate the external MDIO1 node and describe the 8 QSGMII PHYs found on
> > the LS1088ARDB board and add phy-handles for DPMACs 3-10 to its
> > associated PHY.  Also, add the internal PCS MDIO nodes for the internal
> > MDIO buses found on the LS1088A SoC along with their internal PCS PHY
> > and link the corresponding DPMAC to the PCS through the pcs-handle.
> > 
> > Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> > ---
> >   .../boot/dts/freescale/fsl-ls1088a-rdb.dts    | 100 ++++++++++++++++++
> >   .../arm64/boot/dts/freescale/fsl-ls1088a.dtsi |  50 +++++++++
> >   2 files changed, 150 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> > index 5633e59febc3..d7886b084f7f 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> > @@ -17,6 +17,98 @@ / {
> >   	compatible = "fsl,ls1088a-rdb", "fsl,ls1088a";
> >   };
> > +&dpmac3 {
> > +	phy-handle = <&mdio1_phy5>;
> > +	phy-connection-type = "qsgmii";
> > +	managed = "in-band-status";
> > +	pcs-handle = <&pcs3_0>;
> 
> from net-next/master
> 
>  git grep 'pcs-handle' Documentation/devicetree/bindings/*
> zsh: exit 1     git grep 'pcs-handle' Documentation/devicetree/bindings/*
> 
> Is there a binding that we are missing?

I missed adding the new binding description for pcs-handle.
I'll update it in v2.

Thanks,
Ioana