netdev - RE: [PATCH bpf-next] selftests/bpf: properly initialize linfo in sockmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5f774e472c782_38b0208be@john-XPS-13-9370.notmuch>
Date:   Fri, 02 Oct 2020 08:59:03 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Stanislav Fomichev <sdf@...gle.com>, netdev@...r.kernel.org,
        bpf@...r.kernel.org
Cc:     davem@...emloft.net, ast@...nel.org, daniel@...earbox.net,
        Stanislav Fomichev <sdf@...gle.com>
Subject: RE: [PATCH bpf-next] selftests/bpf: properly initialize linfo in
 sockmap_basic

Stanislav Fomichev wrote:
> When using -Werror=missing-braces, compiler complains about missing braces.
> Let's use use ={} initialization which should do the job:
> 
> tools/testing/selftests/bpf/prog_tests/sockmap_basic.c: In function 'test_sockmap_iter':
> tools/testing/selftests/bpf/prog_tests/sockmap_basic.c:181:8: error: missing braces around initializer [-Werror=missing-braces]
>   union bpf_iter_link_info linfo = {0};
>         ^
> tools/testing/selftests/bpf/prog_tests/sockmap_basic.c:181:8: error: (near initialization for 'linfo.map') [-Werror=missing-braces]
> tools/testing/selftests/bpf/prog_tests/sockmap_basic.c: At top level:
> 
> Signed-off-by: Stanislav Fomichev <sdf@...gle.com>
> ---

Works for me.

Acked-by: John Fastabend <john.fastabend@...il.com>

>  tools/testing/selftests/bpf/prog_tests/sockmap_basic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c
> index 4c4224e3e10a..85f73261fab0 100644
> --- a/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c
> +++ b/tools/testing/selftests/bpf/prog_tests/sockmap_basic.c
> @@ -198,7 +198,7 @@ static void test_sockmap_copy(enum bpf_map_type map_type)
>  {
>  	DECLARE_LIBBPF_OPTS(bpf_iter_attach_opts, opts);
>  	int err, len, src_fd, iter_fd, duration = 0;
> -	union bpf_iter_link_info linfo = {0};
> +	union bpf_iter_link_info linfo = {};
>  	__u32 i, num_sockets, num_elems;
>  	struct bpf_iter_sockmap *skel;
>  	__s64 *sock_fd = NULL;
> -- 
> 2.28.0.709.gb0816b6eb0-goog
>