netdev - Re: [net V2 01/15] net/mlx5: Don't allow health work when device is uninitialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e2c09c059b5866f3133d6d880c1f15becc4fc35.camel@kernel.org>
Date:   Fri, 02 Oct 2020 09:57:46 -0700
From:   Saeed Mahameed <saeed@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Shay Drory <shayd@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>
Subject: Re: [net V2 01/15] net/mlx5: Don't allow health work when device is
 uninitialized

On Thu, 2020-10-01 at 16:15 -0700, Jakub Kicinski wrote:
> On Thu,  1 Oct 2020 12:52:33 -0700 saeed@...nel.org wrote:
> > From: Shay Drory <shayd@...lanox.com>
> > 
> > On error flow due to failure on driver load, driver can be
> > un-initializing while a health work is running in the background,
> > health work shouldn't be allowed at this point, as it needs
> > resources to
> > be initialized and there is no point to recover on driver load
> > failures.
> > 
> > Therefore, introducing a new state bit to indicated if device is
> > initialized, for health work to check before trying to recover the
> > driver.
> 
> Can't you cancel this work? Or make sure it's not scheduled?
> IMHO those "INITILIZED" bits are an anti-pattern.
> 

Shay didn't want to make this patch complicated for net, since this
health work should start as early as possible and should be kept
running after driver is initialized, even if the driver instance
reloads after .. the main issue of the design is that we initialize +
allocate the driver structures once on the first boot, after that all
reloads will reuse the same structure, so there is some asymmetry that
we need to deal with, but nothing is impossible, the solution will be
more complicated but won't be too big to make it to net (i hope), I
will drop this patch for now.

> > Fixes: b6e0b6bebe07 ("net/mlx5: Fix fatal error handling during
> > device load")
> > Signed-off-by: Shay Drory <shayd@...lanox.com>
> > Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>
> > Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
> 
> You signed off twice :)
> 

Will fix this, old mellanox email :/

> We should teach verify_signoff to catch that..
it is not exactly twice, different emails..