netdev - Re: [PATCH net-next v2 00/10] genetlink: support per-command policy dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201002142205.5a16fb0f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 2 Oct 2020 14:22:05 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Johannes Berg <johannes@...solutions.net>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, andrew@...n.ch,
        jiri@...nulli.us, mkubecek@...e.cz, dsahern@...nel.org,
        pablo@...filter.org
Subject: Re: [PATCH net-next v2 00/10] genetlink: support per-command policy
 dump

On Fri, 2 Oct 2020 14:17:01 -0700 Jakub Kicinski wrote:
> On Fri, 02 Oct 2020 23:00:15 +0200 Johannes Berg wrote:
> > On Fri, 2020-10-02 at 22:59 +0200, Johannes Berg wrote:  
> > > On Fri, 2020-10-02 at 13:50 -0700, Jakub Kicinski wrote:    
> > > > My thinking was that until kernel actually start using separate dump
> > > > policies user space can assume policy 0 is relevant. But yeah, merging
> > > > your changes first would probably be best.    
> > > 
> > > Works for me. I have it based on yours. Just updated my branch (top
> > > commit is 4d5045adfe90), but I'll probably only actually email it out
> > > once things are a bit more settled wrt. your changes.    
> > 
> > Forgot the link ...
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git/log/?h=genetlink-op-policy-export  
> 
> If it's not too late for you - do you want to merge the two series and
> post everything together? Perhaps squashing patch 10 into something if
> that makes sense?
> 
> You already seem to have it rebased.

FWIW earlier I said:

	if ((op.doit && nla_put_u32(skb, CTRL_whatever_DO, idx)) ||
	    (op.dumpit && nla_put_u32(skb, CTRL_whatever_DUMP, idx)))
		goto nla_put_failure;

 - we should probably also check GENL_DONT_VALIDATE_DUMP here?