netdev - Re: [PATCH] net/smscx5xx: change to of_get_mac_address() eth_platform_get_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6fad98ac-ff25-2954-8d62-85c39c16383c@gmail.com>
Date:   Thu, 1 Oct 2020 19:45:35 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     David Miller <davem@...emloft.net>, l.stelmach@...sung.com
Cc:     steve.glendinning@...well.net, UNGLinuxDriver@...rochip.com,
        kuba@...nel.org, netdev@...r.kernel.org, linux-usb@...r.kernel.org,
        b.zolnierkie@...sung.com, m.szyprowski@...sung.com
Subject: Re: [PATCH] net/smscx5xx: change to of_get_mac_address()
 eth_platform_get_mac_address()



On 10/1/2020 7:05 PM, David Miller wrote:
> From: ийukasz Stelmach <l.stelmach@...sung.com>
> Date: Wed, 30 Sep 2020 16:25:25 +0200
> 
>> Use more generic eth_platform_get_mac_address() which can get a MAC
>> address from other than DT platform specific sources too. Check if the
>> obtained address is valid.
>>
>> Signed-off-by: ийukasz Stelmach <l.stelmach@...sung.com>
> 
> Failure to probe a MAC address should result in the selection of a
> random one.  This way, the interface still comes up and is usable
> even when the MAC address fails to be probed.

True, however this behavior is not changed after this patch is applied, 
I would argue that this should be a separate patch.
-- 
Florian