lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 2 Oct 2020 10:57:42 +0300 From: Petko Manolov <petko.manolov@...sulko.com> To: David Miller <davem@...emloft.net> Cc: netdev@...r.kernel.org Subject: Re: [PATCH] net: usb: pegasus: Proper error handing when setting pegasus' MAC address On 20-10-01 18:42:18, David Miller wrote: > From: Petko Manolov <petko.manolov@...sulko.com> > Date: Tue, 29 Sep 2020 14:40:39 +0300 > > > -static void set_ethernet_addr(pegasus_t *pegasus) > > +static int set_ethernet_addr(pegasus_t *pegasus) > > { > > You change this to return an 'int' but no callers were updated to check it. > > Furthermore, failure to probe a MAC address can be resolved by choosing a > random MAC address. This handling is preferrable because it allows the > interface to still come up successfully. Thanks for looking into this. V2 already sent.
Powered by blists - more mailing lists