netdev - Re: [PATCH net-next] drivers/net/wan/hdlc_fr: Reduce indentation in pvc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 3 Oct 2020 14:27:37 -0700
From:   Xie He <xie.he.0141@...il.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Krzysztof Halasa <khc@...waw.pl>
Subject: Re: [PATCH net-next] drivers/net/wan/hdlc_fr: Reduce indentation in pvc_xmit

On Sat, Oct 3, 2020 at 11:10 AM Stephen Hemminger
<stephen@...workplumber.org> wrote:
>
> This code snippet is basically an version of skb_pad().
> Probably it is very old and pre-dates that.
> Could the code use skb_pad?

Oh! Yes! I looked at the skb_pad function and I think we can use it in
this code.

Since it doesn't do skb_put, I think we can first call skb_pad and
then call skb_put.

Thanks for your suggestion. I'll change this patch to make use of
skb_pad and re-submit.