lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 2 Oct 2020 19:25:01 -0700
From:   Alexei Starovoitov <>
To:     Stanislav Fomichev <>
Cc:     Network Development <>,
        bpf <>,
        "David S. Miller" <>,
        Alexei Starovoitov <>,
        Daniel Borkmann <>
Subject: Re: [PATCH bpf-next] bpf: deref map in BPF_PROG_BIND_MAP when it's
 already used

On Fri, Oct 2, 2020 at 5:25 PM Stanislav Fomichev <> wrote:
> We are missing a deref for the case when we are doing BPF_PROG_BIND_MAP
> on a map that's being already held by the program.
> There is 'if (ret) bpf_map_put(map)' below which doesn't trigger
> because we don't consider this an error.
> Let's add missing bpf_map_put() for this specific condition.
> Fixes: ef15314aa5de ("bpf: Add BPF_PROG_BIND_MAP syscall")
> Reported-by: Alexei Starovoitov <>
> Signed-off-by: Stanislav Fomichev <>

Thanks for the quick fix! Much appreciated.

Powered by blists - more mailing lists