netdev - Re: [PATCH net-next 10/15] sctp: allow changing transport encap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201003040616.GE70998@localhost.localdomain>
Date:   Sat, 3 Oct 2020 01:06:16 -0300
From:   Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org,
        Neil Horman <nhorman@...driver.com>,
        Michael Tuexen <tuexen@...muenster.de>,
        Tom Herbert <therbert@...gle.com>, davem@...emloft.net
Subject: Re: [PATCH net-next 10/15] sctp: allow changing transport encap_port
 by peer packets

On Tue, Sep 29, 2020 at 09:49:02PM +0800, Xin Long wrote:
>  static int sctp_udp_rcv(struct sock *sk, struct sk_buff *skb)
>  {
> +	memset(skb->cb, 0, sizeof(skb->cb));
> +	SCTP_INPUT_CB(skb)->encap_port = ntohs(udp_hdr(skb)->source);

Here it's in host order already. The fact that is does this
transparent update probably hid the other issue.

> +
>  	skb_set_transport_header(skb, sizeof(struct udphdr));
>  	sctp_rcv(skb);
>  	return 0;