netdev - Re: [PATCH net-next 12/15] sctp: call sk_setup_caps in sctp_packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADvbK_cV-yBX-NpPPQxTY+J8OFhv7DvH-UkeprAgtHW+mB0rqg@mail.gmail.com>
Date:   Sat, 3 Oct 2020 15:45:57 +0800
From:   Xin Long <lucien.xin@...il.com>
To:     Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, linux-sctp@...r.kernel.org,
        Neil Horman <nhorman@...driver.com>,
        Michael Tuexen <tuexen@...muenster.de>,
        Tom Herbert <therbert@...gle.com>, davem <davem@...emloft.net>
Subject: Re: [PATCH net-next 12/15] sctp: call sk_setup_caps in
 sctp_packet_transmit instead

On Sat, Oct 3, 2020 at 12:09 PM Marcelo Ricardo Leitner
<marcelo.leitner@...il.com> wrote:
>
> On Tue, Sep 29, 2020 at 09:49:04PM +0800, Xin Long wrote:
> > sk_setup_caps() was originally called in Commit 90017accff61 ("sctp:
> > Add GSO support"), as:
> >
> >   "We have to refresh this in case we are xmiting to more than one
> >    transport at a time"
> >
> > This actually happens in the loop of sctp_outq_flush_transports(),
> > and it shouldn't be gso related, so move it out of gso part and
>
> To be more precise, "shouldn't be tied to gso"
right.

>
> > before sctp_packet_pack().