netdev - Re: [PATCH net-next 11/15] sctp: add udphdr to overhead when udp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADvbK_cPX1f5jrGsKuvya7ssOFPTsG7daBCkOP-NGN9hpzf5Vw@mail.gmail.com>
Date:   Sat, 3 Oct 2020 16:12:58 +0800
From:   Xin Long <lucien.xin@...il.com>
To:     Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Cc:     kernel test robot <lkp@...el.com>,
        network dev <netdev@...r.kernel.org>,
        linux-sctp@...r.kernel.org, kbuild-all@...ts.01.org,
        Neil Horman <nhorman@...driver.com>,
        Michael Tuexen <tuexen@...muenster.de>,
        Tom Herbert <therbert@...gle.com>, davem <davem@...emloft.net>
Subject: Re: [PATCH net-next 11/15] sctp: add udphdr to overhead when udp_port
 is set

On Sat, Oct 3, 2020 at 12:08 PM Marcelo Ricardo Leitner
<marcelo.leitner@...il.com> wrote:
>
> On Wed, Sep 30, 2020 at 03:00:42AM +0800, kernel test robot wrote:
> > Hi Xin,
> >
> > Thank you for the patch! Yet something to improve:
>
> I wonder how are you planning to fix this. It is quite entangled.
> This is not performance critical. Maybe the cleanest way out is to
> move it to a .c file.
>
> Adding a
> #if defined(CONFIG_IP_SCTP) || defined(CONFIG_IP_SCTP_MODULE)
> in there doesn't seem good.
>
> >    In file included from include/net/sctp/checksum.h:27,
> >                     from net/netfilter/nf_nat_proto.c:16:
> >    include/net/sctp/sctp.h: In function 'sctp_mtu_payload':
> > >> include/net/sctp/sctp.h:583:31: error: 'struct net' has no member named 'sctp'; did you mean 'ct'?
> >      583 |   if (sock_net(&sp->inet.sk)->sctp.udp_port)
> >          |                               ^~~~
> >          |                               ct
> >
Here is actually another problem, I'm still thinking how to fix it.

Now sctp_mtu_payload() returns different value depending on
net->sctp.udp_port. but net->sctp.udp_port can be changed by
"sysctl -w" anytime. so:

In sctp_packet_config() it gets overhead/headroom by calling
sctp_mtu_payload(). When 'udp_port' is 0, it's IP+MAC header
size. Then if 'udp_port' is changed to 9899 by 'sysctl -w',
udphdr will also be added to the packet in sctp_v4_xmit(),
and later the headroom may not be enough for IP+MAC headers.

I'm thinking to add sctp_sock->udp_port, and it'll be set when
the sock is created with net->udp_port. but not sure if we should
update sctp_sock->udp_port with  net->udp_port when sending packets?