netdev - Re: [PATCH net] net/core: check length before updating Ethertype in skb_mpls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20201004.142922.2271238418704854925.davem@davemloft.net>
Date:   Sun, 04 Oct 2020 14:29:22 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     martin.varghese@...ia.com
Cc:     gnault@...hat.com, kuba@...nel.org, netdev@...r.kernel.org,
        dcaratti@...hat.com
Subject: Re: [PATCH net] net/core: check length before updating Ethertype
 in skb_mpls_{push,pop}

From: "Varghese, Martin (Nokia - IN/Bangalore)" <martin.varghese@...ia.com>
Date: Sun, 4 Oct 2020 14:50:58 +0000

> Is this check redundant. I believe Openvswitch already takes care of it ?

Openvswitch isn't the only user of these skb_mpls_*() helpers.