netdev - Re: [PATCH net-next] drivers/net/wan/hdlc_fr: Improvements to the code of pvc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20201004.151223.774106080631315758.davem@davemloft.net>
Date:   Sun, 04 Oct 2020 15:12:23 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xie.he.0141@...il.com
Cc:     kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, khc@...waw.pl,
        stephen@...workplumber.org
Subject: Re: [PATCH net-next] drivers/net/wan/hdlc_fr: Improvements to the
 code of pvc_xmit

From: Xie He <xie.he.0141@...il.com>
Date: Sat,  3 Oct 2020 15:41:05 -0700

> 1. Keep the code for the normal (non-error) flow at the lowest
> indentation level. And use "goto drop" for all error handling.
> 
> 2. Replace code that pads short Ethernet frames with a "__skb_pad" call.
> 
> 3. Change "dev_kfree_skb" to "kfree_skb" in error handling code.
> "kfree_skb" is the correct function to call when dropping an skb due to
> an error. "dev_kfree_skb", which is an alias of "consume_skb", is for
> dropping skbs normally (not due to an error).
> 
> Cc: Krzysztof Halasa <khc@...waw.pl>
> Cc: Stephen Hemminger <stephen@...workplumber.org>
> Signed-off-by: Xie He <xie.he.0141@...il.com>

Applied, thank you.