netdev - Re: [PATCH net-next] mptcp: ADD_ADDRs with echo bit are smaller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20201003.173648.767792137065746549.davem@davemloft.net>
Date:   Sat, 03 Oct 2020 17:36:48 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     matthieu.baerts@...sares.net
Cc:     mathew.j.martineau@...ux.intel.com, kuba@...nel.org,
        geliangtang@...il.com, dcaratti@...hat.com, netdev@...r.kernel.org,
        mptcp@...ts.01.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] mptcp: ADD_ADDRs with echo bit are smaller

From: Matthieu Baerts <matthieu.baerts@...sares.net>
Date: Sat,  3 Oct 2020 17:36:56 +0200

> The MPTCP ADD_ADDR suboption with echo-flag=1 has no HMAC, the size is
> smaller than the one initially sent without echo-flag=1. We then need to
> use the correct size everywhere when we need this echo bit.
> 
> Before this patch, the wrong size was reserved but the correct amount of
> bytes were written (and read): the remaining bytes contained garbage.
> 
> Fixes: 6a6c05a8b016 ("mptcp: send out ADD_ADDR with echo flag")
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/95
> Reported-and-tested-by: Davide Caratti <dcaratti@...hat.com>
> Acked-by: Geliang Tang <geliangtang@...il.com>
> Signed-off-by: Matthieu Baerts <matthieu.baerts@...sares.net>

Applied.