[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <cb6ab3a1-914f-545c-fc32-ae63602413f8@gmail.com>
Date: Sun, 4 Oct 2020 09:17:55 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>
Cc: netdev <netdev@...r.kernel.org>,
Vladimir Oltean <vladimir.oltean@....com>,
Jiri Pirko <jiri@...dia.com>, Jakub Kicinski <kuba@...nel.org>,
Vladimir Oltean <olteanv@...il.com>
Subject: Re: [PATCH net-next v3 1/7] net: devlink: Add unused port flavour
On 10/4/2020 9:12 AM, Andrew Lunn wrote:
> Not all ports of a switch need to be used, particularly in embedded
> systems. Add a port flavour for ports which physically exist in the
> switch, but are not connected to the front panel etc, and so are
> unused. By having unused ports present in devlink, it gives a more
> accurate representation of the hardware. It also allows regions to be
> associated to such ports, so allowing, for example, to determine
> unused ports are correctly powered off, or to compare probable reset
> defaults of unused ports to used ports experiences issues.
>
> Actually registering unused ports and setting the flavour to unused is
> optional. The DSA core will register all such switch ports, but such
> ports are expected to be limited in number. Bigger ASICs may decide
> not to list unused ports.
>
> v2:
> Expand the description about why it is useful
>
> Reviewed-by: Vladimir Oltean <olteanv@...il.com>
> Tested-by: Vladimir Oltean <olteanv@...il.com>
> Signed-off-by: Andrew Lunn <andrew@...n.ch>
Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
--
Florian
Powered by blists - more mailing lists