lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20201005161455.62c59f5e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 5 Oct 2020 16:14:55 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Fabian Frederick <fabf@...net.be>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, pablo@...filter.org,
        laforge@...monks.org, steffen.klassert@...unet.com,
        herbert@...dor.apana.org.au, pshelar@....org, dev@...nvswitch.org,
        yoshfuji@...ux-ipv6.org, kuznet@....inr.ac.ru
Subject: Re: [PATCH 1/9 net-next] net: netdevice.h: sw_netstats_rx_add
 helper

On Mon,  5 Oct 2020 22:34:18 +0200 Fabian Frederick wrote:
> +static inline void dev_sw_netstats_rx_add(struct net_device *dev, unsigned int len)
> +{
> +	struct pcpu_sw_netstats *tstats = this_cpu_ptr(dev->tstats);
> +
> +	u64_stats_update_begin(&tstats->syncp);
> +	tstats->rx_bytes += len;
> +	tstats->rx_packets++;
> +	u64_stats_update_end(&tstats->syncp);
> +

checkpatch points out there is an unnecessary empty line here

> +}

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ