lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 5 Oct 2020 10:29:35 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Bastien Nocera <hadess@...ess.net>
Cc:     Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Sathish Narsimman <sathish.narasimman@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        linux-bluetooth <linux-bluetooth@...r.kernel.org>,
        "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "Bluetooth: Update resolving list when updating
 whitelist"

On Sun, Oct 04, 2020 at 03:23:18PM +0200, Bastien Nocera wrote:
> On Sun, 2020-10-04 at 15:18 +0200, Greg Kroah-Hartman wrote:
> > On Sun, Oct 04, 2020 at 02:17:06PM +0200, Bastien Nocera wrote:
> > > On Sun, 2020-10-04 at 12:51 +0200, Greg Kroah-Hartman wrote:
> > > > On Sat, Oct 03, 2020 at 08:33:18PM +0200, Marcel Holtmann wrote:
> > > > > Hi Greg,
> > > > > 
> > > > > > > > This reverts commit
> > > > > > > > 0eee35bdfa3b472cc986ecc6ad76293fdcda59e2
> > > > > > > > as it
> > > > > > > > breaks all bluetooth connections on my machine.
> > > > > > > > 
> > > > > > > > Cc: Marcel Holtmann <marcel@...tmann.org>
> > > > > > > > Cc: Sathish Narsimman <sathish.narasimman@...el.com>
> > > > > > > > Fixes: 0eee35bdfa3b ("Bluetooth: Update resolving list
> > > > > > > > when
> > > > > > > > updating whitelist")
> > > > > > > > Signed-off-by: Greg Kroah-Hartman
> > > > > > > > <gregkh@...uxfoundation.org>
> > > > > > > > ---
> > > > > > > > net/bluetooth/hci_request.c | 41 ++----------------------
> > > > > > > > ----
> > > > > > > > ---------
> > > > > > > > 1 file changed, 2 insertions(+), 39 deletions(-)
> > > > > > > > 
> > > > > > > > This has been bugging me for since 5.9-rc1, when all
> > > > > > > > bluetooth devices
> > > > > > > > stopped working on my desktop system.  I finally got the
> > > > > > > > time
> > > > > > > > to do
> > > > > > > > bisection today, and it came down to this patch. 
> > > > > > > > Reverting
> > > > > > > > it on top of
> > > > > > > > 5.9-rc7 restored bluetooth devices and now my input
> > > > > > > > devices
> > > > > > > > properly
> > > > > > > > work.
> > > > > > > > 
> > > > > > > > As it's almost 5.9-final, any chance this can be merged
> > > > > > > > now
> > > > > > > > to fix the
> > > > > > > > issue?
> > > > > > > 
> > > > > > > can you be specific what breaks since our guys and I also
> > > > > > > think
> > > > > > > the
> > > > > > > ChromeOS guys have been testing these series of patches
> > > > > > > heavily.
> > > > > > 
> > > > > > My bluetooth trackball does not connect at all.  With this
> > > > > > reverted, it
> > > > > > all "just works".
> > > > > > 
> > > > > > Same I think for a Bluetooth headset, can check that again if
> > > > > > you
> > > > > > really
> > > > > > need me to, but the trackball is reliable here.
> > > > > > 
> > > > > > > When you run btmon does it indicate any errors?
> > > > > > 
> > > > > > How do I run it and where are the errors displayed?
> > > > > 
> > > > > you can do btmon -w trace.log and just let it run like tcdpump.
> > > > 
> > > > Ok, attached.
> > > > 
> > > > The device is not connecting, and then I open the gnome bluetooth
> > > > dialog
> > > > and it scans for devices in the area, but does not connect to my
> > > > existing devices at all.
> > > > 
> > > > Any ideas?
> > > 
> > > Use bluetoothctl instead, the Bluetooth Settings from GNOME also
> > > run a
> > > discovery the whole time the panel is opened, and this breaks a
> > > fair
> > > number of poor quality adapters. This is worked-around in the most
> > > recent version, but using bluetoothctl is a better debugging option
> > > in
> > > all cases.
> > 
> > Ok, but how do I use that tool?  How do I shut down the gnome
> > bluetooth
> > stuff?
> 
> You close the settings window...
> 
> > I need newbie steps here please for what to run and what to show you.
> 
> bluetoothctl connect "bluetooth address"
> eg.
> bluetoothctl connect "12:34:56:78:90"

Ok, here that is on a clean 5.9-rc8 release:

$ bluetoothctl connect F1:85:91:79:73:70
Attempting to connect to F1:85:91:79:73:70
Failed to connect: org.bluez.Error.Failed

I've attached the trace log from that effort.

I'll go try Marcel's proposed patch now as well...

thanks,

greg k-h

View attachment "trace.log" of type "text/plain" (663 bytes)

Powered by blists - more mailing lists