lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 5 Oct 2020 16:01:33 +0200 From: Krzysztof Kozlowski <krzk@...nel.org> To: Łukasz Stelmach <l.stelmach@...sung.com> Cc: "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Kukjin Kim <kgene@...nel.org>, Rob Herring <robh+dt@...nel.org>, Russell King <linux@...linux.org.uk>, Andrew Lunn <andrew@...n.ch>, jim.cromie@...il.com, linux-arm-kernel@...ts.infradead.org, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-samsung-soc@...r.kernel.org" <linux-samsung-soc@...r.kernel.org>, netdev@...r.kernel.org, devicetree@...r.kernel.org, Bartłomiej Żolnierkiewicz <b.zolnierkie@...sung.com>, Marek Szyprowski <m.szyprowski@...sung.com> Subject: Re: [PATCH v2 1/4] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter On Fri, 2 Oct 2020 at 21:22, Łukasz Stelmach <l.stelmach@...sung.com> wrote: > > Add bindings for AX88796C SPI Ethernet Adapter. > > Signed-off-by: Łukasz Stelmach <l.stelmach@...sung.com> > --- > .../bindings/net/asix,ax88796c-spi.yaml | 76 +++++++++++++++++++ > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > 2 files changed, 78 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/asix,ax88796c-spi.yaml > > diff --git a/Documentation/devicetree/bindings/net/asix,ax88796c-spi.yaml b/Documentation/devicetree/bindings/net/asix,ax88796c-spi.yaml > new file mode 100644 > index 000000000000..50a488d59dbf > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/asix,ax88796c-spi.yaml > @@ -0,0 +1,76 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/asix,ax88796c-spi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ASIX AX88796C SPI Ethernet Adapter > + > +allOf: > + - $ref: ethernet-controller.yaml# > + > +description: | > + ASIX AX88796C is an Ethernet controller with a built in PHY. This > + describes SPI mode of the chip. > + > + The node for this driver must be a child node of a SPI controller, hence > + all mandatory properties described in ../spi/spi-bus.txt must be specified. > + > +maintainers: > + - Łukasz Stelmach <l.stelmach@...sung.com> > + > +properties: > + compatible: > + const: asix,ax99796c-spi > + > + reg: > + description: > + SPI device address. > + maxItems: 1 > + > + spi-max-frequency: > + maximum: 40000000 > + > + interrupts: > + description: > + GPIO interrupt to which the chip is connected. > + maxItems: 1 > + > + interrupt-parrent: > + description: > + A phandle of an interrupt controller. > + maxItems: 1 > + > + reset-gpios: > + description: > + A GPIO line handling reset of the chip. As the line is active low, > + it should be marked GPIO_ACTIVE_LOW. > + maxItems: 1 > + > + local-mac-address: true > + > + mac-address: true > + > +required: > + - compatible > + - reg > + - spi-max-frequency > + - interrupts > + - interrupt-parrent > + - reset-gpios > + > +examples: > + # Artik5 eval board > + - | > + ax88796c@0 { > + compatible = "asix,ax88796c"; > + local-mac-address = [00 00 00 00 00 00]; /* Filled in by a bootloader */ > + interrupt-parent = <&gpx2>; > + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > + spi-max-frequency = <40000000>; > + reg = <0x0>; > + reset-gpios = <&gpe0 2 GPIO_ACTIVE_LOW>; This and IRQ won't compile without defines, which Rob's robot just pointed out. It seems you did not test the bindings you post. Best regards, Krzysztof
Powered by blists - more mailing lists