lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 05 Oct 2020 08:14:29 +0200
From:   Kurt Kanzenbach <kurt@...utronix.de>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Richard Cochran <richardcochran@...il.com>,
        Kamil Alkhouri <kamil.alkhouri@...offenburg.de>,
        ilias.apalodimas@...aro.org
Subject: Re: [PATCH net-next v6 1/7] net: dsa: Add tag handling for Hirschmann Hellcreek switches

On Sun Oct 04 2020, Vladimir Oltean wrote:
> On Sun, Oct 04, 2020 at 01:29:05PM +0200, Kurt Kanzenbach wrote:
>> +static const struct dsa_device_ops hellcreek_netdev_ops = {
>> +	.name	  = "hellcreek",
>> +	.proto	  = DSA_TAG_PROTO_HELLCREEK,
>> +	.xmit	  = hellcreek_xmit,
>> +	.rcv	  = hellcreek_rcv,
>> +	.overhead = HELLCREEK_TAG_LEN,
>
> After the changes in "Generic adjustment for flow dissector in DSA":
> https://patchwork.ozlabs.org/project/netdev/list/?series=204347&state=*
> you might want to set ".tail_tag = true" (see patch 07/15), either now
> or later.
>
> Either way,
>
> Reviewed-by: Vladimir Oltean <olteanv@...il.com>

Added it.

Thanks,
Kurt

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)

Powered by blists - more mailing lists