netdev - Re: [PATCH net] mptcp: more DATA FIN fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20201006.060744.1614882032086190689.davem@davemloft.net>
Date:   Tue, 06 Oct 2020 06:07:44 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, mptcp@...ts.01.org
Subject: Re: [PATCH net] mptcp: more DATA FIN fixes

From: Paolo Abeni <pabeni@...hat.com>
Date: Mon,  5 Oct 2020 12:01:06 +0200

> Currently data fin on data packet are not handled properly:
> the 'rcv_data_fin_seq' field is interpreted as the last
> sequence number carrying a valid data, but for data fin
> packet with valid maps we currently store map_seq + map_len,
> that is, the next value.
> 
> The 'write_seq' fields carries instead the value subseguent
> to the last valid byte, so in mptcp_write_data_fin() we
> never detect correctly the last DSS map.
> 
> Fixes: 7279da6145bb ("mptcp: Use MPTCP-level flag for sending DATA_FIN")
> Fixes: 1a49b2c2a501 ("mptcp: Handle incoming 32-bit DATA_FIN values")
> Reviewed-by: Mat Martineau <mathew.j.martineau@...ux.intel.com>
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Applied.