netdev - Re: [PATCH v4] net: usb: rtl8150: set random MAC address when set_ethernet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 06 Oct 2020 06:10:41 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     anant.thazhemadam@...il.com
Cc:     linux-kernel-mentees@...ts.linuxfoundation.org, joe@...ches.com,
        syzbot+abbc768b560c84d92fd3@...kaller.appspotmail.com,
        petkan@...leusys.com, kuba@...nel.org, linux-usb@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] net: usb: rtl8150: set random MAC address when
 set_ethernet_addr() fails

From: Anant Thazhemadam <anant.thazhemadam@...il.com>
Date: Mon,  5 Oct 2020 18:59:58 +0530

> When get_registers() fails in set_ethernet_addr(),the uninitialized
> value of node_id gets copied over as the address.
> So, check the return value of get_registers().
> 
> If get_registers() executed successfully (i.e., it returns
> sizeof(node_id)), copy over the MAC address using ether_addr_copy()
> (instead of using memcpy()).
> 
> Else, if get_registers() failed instead, a randomly generated MAC
> address is set as the MAC address instead.
> 
> Reported-by: syzbot+abbc768b560c84d92fd3@...kaller.appspotmail.com
> Tested-by: syzbot+abbc768b560c84d92fd3@...kaller.appspotmail.com
> Acked-by: Petko Manolov <petkan@...leusys.com>
> Signed-off-by: Anant Thazhemadam <anant.thazhemadam@...il.com>

Applied, thank you.