netdev - Re: [PATCH net-next v6 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201006141016.pxsmf4qy762mbhtj@skbuf>
Date:   Tue, 6 Oct 2020 17:10:16 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Kurt Kanzenbach <kurt@...utronix.de>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Richard Cochran <richardcochran@...il.com>,
        Kamil Alkhouri <kamil.alkhouri@...offenburg.de>,
        ilias.apalodimas@...aro.org
Subject: Re: [PATCH net-next v6 2/7] net: dsa: Add DSA driver for Hirschmann
 Hellcreek switches

On Tue, Oct 06, 2020 at 04:05:11PM +0200, Kurt Kanzenbach wrote:
> > And because my knob is global and not per bridge either, I just set
> > ds->vlan_filtering_is_global = true and let DSA handle the rest.
>
> What's that flag doing? ...
>
> 	/* Disallow bridge core from requesting different VLAN awareness
> 	 * settings on ports if not hardware-supported
> 	 */
> 	bool			vlan_filtering_is_global;
>
> OK, that's what I need for the bridging part.

Yes, with the mention that not all checks for 8021q uppers may be in
place properly today. But we are in a better position of adding those
checks now, since we have a good place to start in
dsa_slave_netdevice_event. If you find scenarios that should be rejected
when this flag is set, but aren't, let me know and we'll fix that.
Nonetheless, if you go this route, then yes, you should set that flag.