netdev - Re: [RESEND net-next 1/8] net: dccp: convert tasklets to use new tasklet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201006074204.2bd6fd32@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 6 Oct 2020 07:42:04 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Allen Pais <allen.lkml@...il.com>
Cc:     davem@...emloft.net, gerrit@....abdn.ac.uk, edumazet@...gle.com,
        kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        johannes@...solutions.net, alex.aring@...il.com,
        stefan@...enfreihafen.org, santosh.shilimkar@...cle.com,
        jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        steffen.klassert@...unet.com, herbert@...dor.apana.org.au,
        netdev@...r.kernel.org, Romain Perier <romain.perier@...il.com>,
        Allen Pais <apais@...ux.microsoft.com>
Subject: Re: [RESEND net-next 1/8] net: dccp: convert tasklets to use new
 tasklet_setup() API

On Tue,  6 Oct 2020 12:01:54 +0530 Allen Pais wrote:
> --- a/net/dccp/timer.c
> +++ b/net/dccp/timer.c
> @@ -219,9 +219,10 @@ static void dccp_delack_timer(struct timer_list *t)
>   *
>   * See the comments above %ccid_dequeueing_decision for supported modes.
>   */
> -static void dccp_write_xmitlet(unsigned long data)
> +static void dccp_write_xmitlet(struct tasklet_struct *t)

net/dccp/timer.c:223: warning: Function parameter or member 't' not described in 'dccp_write_xmitlet'
net/dccp/timer.c:223: warning: Excess function parameter 'data' description in 'dccp_write_xmitlet'