netdev - RE: [PATCH][RESEND] net: fec: Fix PHY init after phy_reset_after_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <f3ff40567ee44fc3a14b2ae8a9b18180@dh-electronics.com>
Date:   Tue, 6 Oct 2020 19:07:14 +0000
From:   Christoph Niedermaier <cniedermaier@...electronics.com>
To:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     Andrew Lunn <andrew@...n.ch>,
        Richard Leitner <richard.leitner@...data.com>,
        "David S . Miller" <davem@...emloft.net>,
        "NXP Linux Team" <linux-imx@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        "'Marek Vasut'" <marex@...x.de>,
        Christoph Niedermaier <cniedermaier@...electronics.com>
Subject: RE: [PATCH][RESEND] net: fec: Fix PHY init after
 phy_reset_after_clk_enable() [Klartext]

From: Marek Vasut <marex@...x.de>
Sent: Tuesday, October 6, 2020 3:53 PM

> The phy_reset_after_clk_enable() does a PHY reset, which means the PHY
> loses its register settings. The fec_enet_mii_probe() starts the PHY
> and does the necessary calls to configure the PHY via PHY framework,
> and loads the correct register settings into the PHY. Therefore,
> fec_enet_mii_probe() should be called only after the PHY has been
> reset, not before as it is now.
> 
> Fixes: 1b0a83ac04e3 ("net: fec: add phy_reset_after_clk_enable() support")
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Tested-by: Richard Leitner <richard.leitner@...data.com>
> Signed-off-by: Marek Vasut <marex@...x.de>
> Cc: Christoph Niedermaier <cniedermaier@...electronics.com>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: NXP Linux Team <linux-imx@....com>
> Cc: Richard Leitner <richard.leitner@...data.com>
> Cc: Shawn Guo <shawnguo@...nel.org>
> ---
>  drivers/net/ethernet/freescale/fec_main.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index c043afb38b6e..2d5433301843 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -2983,17 +2983,17 @@ fec_enet_open(struct net_device *ndev)
>         /* Init MAC prior to mii bus probe */
>         fec_restart(ndev);
> 
> -       /* Probe and connect to PHY when open the interface */
> -       ret = fec_enet_mii_probe(ndev);
> -       if (ret)
> -               goto err_enet_mii_probe;
> -
>         /* Call phy_reset_after_clk_enable() again if it failed during
>          * phy_reset_after_clk_enable() before because the PHY wasn't
> probed.
>          */
>         if (reset_again)
>                 phy_reset_after_clk_enable(ndev->phydev);
> 
> +       /* Probe and connect to PHY when open the interface */
> +       ret = fec_enet_mii_probe(ndev);
> +       if (ret)
> +               goto err_enet_mii_probe;
> +
>         if (fep->quirks & FEC_QUIRK_ERR006687)
>                 imx6q_cpuidle_fec_irqs_used();
> 
> --
> 2.28.0

Tested-by: Christoph Niedermaier <cniedermaier@...electronics.com>