netdev - Re: [PATCH net-next v2 01/10] dt-bindings: net: add the dpaa2-mac DTS definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201006205635.GA2810492@bogus>
Date:   Tue, 6 Oct 2020 15:56:35 -0500
From:   Rob Herring <robh@...nel.org>
To:     Ioana Ciornei <ioana.ciornei@....com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, shawnguo@...nel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH net-next v2 01/10] dt-bindings: net: add the dpaa2-mac
 DTS definition

On Sat, Oct 03, 2020 at 12:07:28AM +0300, Ioana Ciornei wrote:
> Add a documentation entry for the DTS bindings needed and supported by
> the dpaa2-mac driver.
> 
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>
> ---
> Changes in v2:
>  - new patch
> 
>  .../devicetree/bindings/net/dpaa2-mac.yaml    | 55 +++++++++++++++++++

Use the compatible string for the filename.

>  1 file changed, 55 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/dpaa2-mac.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/dpaa2-mac.yaml b/Documentation/devicetree/bindings/net/dpaa2-mac.yaml
> new file mode 100644
> index 000000000000..744b0590278d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/dpaa2-mac.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/dpaa2-mac.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: DPAA2 MAC bindings
> +
> +maintainers:
> +  - Ioana Ciornei <ioana.ciornei@....com>
> +
> +description:
> +  This binding represents the DPAA2 MAC objects found on the fsl-mc bus and
> +  located under the 'dpmacs' node for the fsl-mc bus DTS node.

Need $ref to ethernet-controller.yaml

> +
> +properties:
> +  compatible:
> +    const: "fsl,qoriq-mc-dpmac"

Don't need quotes.

> +
> +  reg:
> +    maxItems: 1
> +    description: The DPMAC number
> +
> +  phy-handle: true
> +
> +  phy-connection-type: true
> +
> +  phy-mode: true
> +
> +  pcs-handle:
> +    $ref: /schemas/types.yaml#definitions/phandle
> +    description:
> +      A reference to a node representing a PCS PHY device found on
> +      the internal MDIO bus.

Perhaps use the 'phys' binding? (Too many PHYs with ethernet...)

This would be the on-chip XAUI/SerDes phy? That's typically 'phys' where 
as 'phy-handle' is ethernet PHY. 

> +
> +  managed: true
> +
> +required:
> +  - reg

addtionalProperties: false

> +
> +examples:
> +  - |
> +    dpmacs {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      dpmac@4 {

ethernet@4

> +        compatible = "fsl,qoriq-mc-dpmac";
> +        reg = <0x4>;
> +        phy-handle = <&mdio1_phy6>;
> +        phy-connection-type = "qsgmii";
> +        managed = "in-band-status";
> +        pcs-handle = <&pcs3_1>;
> +      };
> +    };
> -- 
> 2.28.0
>