lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 5 Oct 2020 19:12:29 -0700
From:   Kees Cook <>
To:     Thibaut Sautereau <>
Cc:     "David S . Miller" <>,
        Jakub Kicinski <>,,,,
        Thibaut Sautereau <>,
        Linus Torvalds <>,
        Willy Tarreau <>, Emese Revfy <>,
        Theodore Ts'o <>,
        Andrew Morton <>
Subject: Re: [PATCH] random32: Restore __latent_entropy attribute on

On Fri, Oct 02, 2020 at 05:16:11PM +0200, Thibaut Sautereau wrote:
> From: Thibaut Sautereau <>
> Commit f227e3ec3b5c ("random32: update the net random state on interrupt
> and activity") broke compilation and was temporarily fixed by Linus in
> 83bdc7275e62 ("random32: remove net_rand_state from the latent entropy
> gcc plugin") by entirely moving net_rand_state out of the things handled
> by the latent_entropy GCC plugin.
> From what I understand when reading the plugin code, using the
> __latent_entropy attribute on a declaration was the wrong part and
> simply keeping the __latent_entropy attribute on the variable definition
> was the correct fix.
> Fixes: 83bdc7275e62 ("random32: remove net_rand_state from the latent entropy gcc plugin")
> Cc: Linus Torvalds <>
> Cc: Willy Tarreau <>
> Cc: Emese Revfy <>
> Signed-off-by: Thibaut Sautereau <>

Yes, that looks correct. Thank you!

Acked-by: Kees Cook <>

I'm not sure the best tree for this. Ted, Andrew, Linus? I'll take it
via my gcc plugin tree if no one else takes it. :)

Kees Cook

Powered by blists - more mailing lists