netdev - Re: [PATCH net-next v2 0/7] ethtool: allow dumping policies to user space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7586c9e77f6aa43e598103ccc25b43415752507d.camel@sipsolutions.net>
Date:   Tue, 06 Oct 2020 08:43:17 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, kernel-team@...com, jiri@...nulli.us,
        andrew@...n.ch, mkubecek@...e.cz
Subject: Re: [PATCH net-next v2 0/7] ethtool: allow dumping policies to user
 space

On Mon, 2020-10-05 at 15:07 -0700, Jakub Kicinski wrote:
> Hi!
> 
> This series wires up ethtool policies to ops, so they can be
> dumped to user space for feature discovery.
> 
> First patch wires up GET commands, and second patch wires up SETs.
> 
> The policy tables are trimmed to save space and LoC.
> 
> Next - take care of linking up nested policies for the header
> (which is the policy what we actually care about). And once header
> policy is linked make sure that attribute range validation for flags
> is done by policy, not a conditions in the code. New type of policy
> is needed to validate masks (patch 6).
> 
> Netlink as always staying a step ahead of all the other kernel
> API interfaces :)
> 
> v2:
>  - merge patches 1 & 2 -> 1
>  - add patch 3 & 5
>  - remove .max_attr from struct ethnl_request_ops
> 

Looks good!

Reviewed-by: Johannes Berg <johannes@...solutions.net>

johannes