netdev - Re: [PATCH v2 3/4] ARM: dts: exynos: Add Ethernet to Artik 5 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Oct 2020 12:17:02 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Lukasz Stelmach <l.stelmach@...sung.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Kukjin Kim <kgene@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Russell King <linux@...linux.org.uk>,
        Andrew Lunn <andrew@...n.ch>, jim.cromie@...il.com,
        linux-arm-kernel@...ts.infradead.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org,
        Bartłomiej Żolnierkiewicz 
        <b.zolnierkie@...sung.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH v2 3/4] ARM: dts: exynos: Add Ethernet to Artik 5 board

On Tue, 6 Oct 2020 at 12:06, Lukasz Stelmach <l.stelmach@...sung.com> wrote:
>
> It was <2020-10-03 sob 12:13>, when Krzysztof Kozlowski wrote:
> > On Fri, 2 Oct 2020 at 21:22, Łukasz Stelmach <l.stelmach@...sung.com> wrote:
> >>
> >> Add node for ax88796c ethernet chip.
> >>
> >> Signed-off-by: Łukasz Stelmach <l.stelmach@...sung.com>
> >> ---
> >>  arch/arm/boot/dts/exynos3250-artik5-eval.dts | 21 ++++++++++++++++++++
> >>  1 file changed, 21 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos3250-artik5-eval.dts b/arch/arm/boot/dts/exynos3250-artik5-eval.dts
> >> index 20446a846a98..7f115c348a2a 100644
> >> --- a/arch/arm/boot/dts/exynos3250-artik5-eval.dts
> >> +++ b/arch/arm/boot/dts/exynos3250-artik5-eval.dts
> >> @@ -37,3 +37,24 @@ &mshc_2 {
> >>  &serial_2 {
> >>         status = "okay";
> >>  };
> >> +
> >> +&spi_0 {
> >> +       status = "okay";
> >> +       cs-gpios = <&gpx3 4 GPIO_ACTIVE_LOW>, <0>;
> >> +
> >> +       assigned-clocks        = <&cmu CLK_MOUT_MPLL>, <&cmu CLK_DIV_MPLL_PRE>, <&cmu CLK_MOUT_SPI0>,    <&cmu CLK_DIV_SPI0>,  <&cmu CLK_DIV_SPI0_PRE>, <&cmu CLK_SCLK_SPI0>;
> >
> > No spaces before or after '='.
> >
>
> You mean " = ", don't you?

Ah, of course.

>
> >> + assigned-clock-parents = <&cmu CLK_FOUT_MPLL>, <&cmu
> >> CLK_MOUT_MPLL>, <&cmu CLK_DIV_MPLL_PRE>, <&cmu CLK_MOUT_SPI0>, <&cmu
> >> CLK_DIV_SPI0>, <&cmu CLK_DIV_SPI0_PRE>;
> >
> > This line is still too long. Please wrap it at 80. Checkpatch should
> > complain about it... so it seems you did not run it. Please fix all
> > checkpatch issues.
>
> My idea was too keep assigned-clocks and assigned-clock-parrent lines
> aligned, so it is clearly visible which parrent applies to which
> clock. Is it inappropriate?

The line gets too long and in the existing DTSes we wrapped item by
item. Solution could be to add comments, e.g.:
assigned-clock-parents = <&cmu CLK_FOUT_MPLL>,
           <&cmu CLK_DIV_MPLL_PRE>, /* for: CLK_DIV_MPLL_PRE */
           <&cmu CLK_MOUT_SPI0>, /* for: CLK_MOUT_SPI0 */

but I am not sure if dtc allows such comments.

Best regards,
Krzysztof