netdev - Re: [PATCH net-next] net: dsa: microchip: add ksz9563 to ksz9477 I2C driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201007131951.GF56634@lunn.ch>
Date:   Wed, 7 Oct 2020 15:19:51 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Christian Eggers <ceggers@...i.de>
Cc:     Woojung Huh <woojung.huh@...rochip.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: microchip: add ksz9563 to ksz9477 I2C
 driver

On Wed, Oct 07, 2020 at 03:13:15PM +0200, Christian Eggers wrote:
> Hi Andrew,
> 
> > What chip_id values does it use? I don't see it listed in
> > ksz9477_switch_chips.
> 
> here a short dump of the first chip registers:
> 
> >         Chip ID0     00
> >         Chip ID1_2   9893      Chip ID      9893
> >         Chip ID3     60        Revision ID  6              Reset         normal
> >         Chip ID4     1C        SKU ID       1C
> 
> In ksz9477_switch_detect(), the 32 bit value is built from only
> the 2 middle bytes: 0x00989300. The number of port (3) is also
> assigned within this function:
> 
> > 	if ((id_lo & 0xf) == 3) {
> > 		/* Chip is from KSZ9893 design. */
> > 		dev->features |= IS_9893;
> > 		/* Chip does not support gigabit. */
> > 		if (data8 & SW_QW_ABLE)
> > 			dev->features &= ~GBIT_SUPPORT;
> > 		dev->mib_port_cnt = 3;
> > 		dev->phy_port_cnt = 2;
> > 	} ...
> 
> The chip id 0x00989300 does already exist in ksz9477_switch_chips:
> 
> > 	{
> > 		.chip_id = 0x00989300,
> > 		.dev_name = "KSZ9893",

O.K. Thanks. This is not very clear. Maybe add a follow up patch which
adds some comments?

     Andrew