netdev - Re: [PATCH 2/2] ethtool: correct policy for ETHTOOL_MSG_CHANNELS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20201007081239.4b47580f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 7 Oct 2020 08:12:39 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Johannes Berg <johannes@...solutions.net>
Cc:     netdev@...r.kernel.org, Leon Romanovsky <leon@...nel.org>,
        Johannes Berg <johannes.berg@...el.com>
Subject: Re: [PATCH 2/2] ethtool: correct policy for
 ETHTOOL_MSG_CHANNELS_SET

On Wed,  7 Oct 2020 12:53:51 +0200 Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@...el.com>
> 
> This accidentally got wired up to the *get* policy instead
> of the *set* policy, causing operations to be rejected. Fix
> it by wiring up the correct policy instead.
> 
> Fixes: 5028588b62cb ("ethtool: wire up set policies to ops")
> Reported-by: Leon Romanovsky <leon@...nel.org>
> Signed-off-by: Johannes Berg <johannes.berg@...el.com>

Reviewed-by: Jakub Kicinski <kuba@...nel.org>

Thanks!