netdev - Re: [net-next v2 6/8] net: sched: convert tasklets to use new tasklet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5f057822-0d9a-0643-6a1e-118e306c6bb1@gmail.com>
Date:   Wed, 7 Oct 2020 18:52:17 +0200
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Allen Pais <allen.lkml@...il.com>, davem@...emloft.net
Cc:     gerrit@....abdn.ac.uk, kuba@...nel.org, edumazet@...gle.com,
        kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        johannes@...solutions.net, alex.aring@...il.com,
        stefan@...enfreihafen.org, santosh.shilimkar@...cle.com,
        jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        steffen.klassert@...unet.com, herbert@...dor.apana.org.au,
        netdev@...r.kernel.org, Allen Pais <apais@...ux.microsoft.com>,
        Romain Perier <romain.perier@...il.com>
Subject: Re: [net-next v2 6/8] net: sched: convert tasklets to use new
 tasklet_setup() API



On 10/7/20 12:12 PM, Allen Pais wrote:
> From: Allen Pais <apais@...ux.microsoft.com>
> 
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly.
> 
> Signed-off-by: Romain Perier <romain.perier@...il.com>
> Signed-off-by: Allen Pais <apais@...ux.microsoft.com>
> ---
>  net/sched/sch_atm.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/net/sched/sch_atm.c b/net/sched/sch_atm.c
> index 1c281cc81..0a4452178 100644
> --- a/net/sched/sch_atm.c
> +++ b/net/sched/sch_atm.c
> @@ -466,10 +466,11 @@ drop: __maybe_unused
>   * non-ATM interfaces.
>   */
>  
> -static void sch_atm_dequeue(unsigned long data)
> +static void sch_atm_dequeue(struct tasklet_struct *t)
>  {
> -	struct Qdisc *sch = (struct Qdisc *)data;
> -	struct atm_qdisc_data *p = qdisc_priv(sch);
> +	struct atm_qdisc_data *p = from_tasklet(p, t, task);
> +	struct Qdisc *sch = (struct Qdisc *)((char *) p -
> +					     QDISC_ALIGN(sizeof(struct Qdisc)));

Oh well. I would rather get rid of QDISC_ALIGN() completely, instead
of spreading it all over the places.

I have sent https://patchwork.ozlabs.org/project/netdev/patch/20201007165111.172419-1-eric.dumazet@gmail.com/