[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20201007213549.GF48010@ranger.igk.intel.com>
Date: Wed, 7 Oct 2020 23:35:49 +0200
From: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
To: sven.auhagen@...eatech.de
Cc: anthony.l.nguyen@...el.com, davem@...emloft.net,
netdev@...r.kernel.org, nhorman@...hat.com, sassmann@...hat.com,
sandeep.penigalapati@...el.com, brouer@...hat.com
Subject: Re: [PATCH 7/7] igb: avoid transmit queue timeout in xdp path
On Wed, Oct 07, 2020 at 05:25:06PM +0200, sven.auhagen@...eatech.de wrote:
> From: Sven Auhagen <sven.auhagen@...eatech.de>
>
> Since we share the transmit queue with the slow path,
> it is possible that we run into a transmit queue timeout.
> This will reset the queue.
> This happens under high load when the fast path is using the
> transmit queue pretty much exclusively.
Please mention in the commit message *how* you are fixing this issue.
>
> Signed-off-by: Sven Auhagen <sven.auhagen@...eatech.de>
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
> index 6a2828b96eef..d84a99359e95 100644
> --- a/drivers/net/ethernet/intel/igb/igb_main.c
> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> @@ -2916,6 +2916,8 @@ static int igb_xdp_xmit_back(struct igb_adapter *adapter, struct xdp_buff *xdp)
>
> nq = txring_txq(tx_ring);
> __netif_tx_lock(nq, cpu);
> + /* Avoid transmit queue timeout since we share it with the slow path */
> + nq->trans_start = jiffies;
> ret = igb_xmit_xdp_ring(adapter, tx_ring, xdpf);
> __netif_tx_unlock(nq);
>
> @@ -2948,6 +2950,9 @@ static int igb_xdp_xmit(struct net_device *dev, int n,
> nq = txring_txq(tx_ring);
> __netif_tx_lock(nq, cpu);
>
> + /* Avoid transmit queue timeout since we share it with the slow path */
> + nq->trans_start = jiffies;
> +
> for (i = 0; i < n; i++) {
> struct xdp_frame *xdpf = frames[i];
> int err;
> --
> 2.20.1
>
Powered by blists - more mailing lists