[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20201008001025.292064-1-andrii@kernel.org>
Date: Wed, 7 Oct 2020 17:10:20 -0700
From: Andrii Nakryiko <andrii@...nel.org>
To: <bpf@...r.kernel.org>, <netdev@...r.kernel.org>, <ast@...com>,
<daniel@...earbox.net>
CC: <andrii@...nel.org>, <kernel-team@...com>,
Luka Perkov <luka.perkov@...tura.hr>,
Tony Ambardar <tony.ambardar@...il.com>
Subject: [PATCH v3 bpf-next 0/4] libbpf: auto-resize relocatable LOAD/STORE instructions
Patch set implements logic in libbpf to auto-adjust memory size (1-, 2-, 4-,
8-bytes) of load/store (LD/ST/STX) instructions which have BPF CO-RE field
offset relocation associated with it. In practice this means transparent
handling of 32-bit kernels, both pointer and unsigned integers. Signed
integers are not relocatable with zero-extending loads/stores, so libbpf
poisons them and generates a warning. If/when BPF gets support for
sign-extending loads/stores, it would be possible to automatically relocate
them as well.
All the details are contained in patch #2 comments and commit message.
Patch #3 is a simple change in libbpf to make advanced testing with custom BTF
easier. Patch #4 validates correct uses of auto-resizable loads, as well as
check that libbpf fails invalid uses. Patch #1 skips CO-RE relocation for
programs that had bpf_program__set_autoload(prog, false) set on them, reducing
warnings and noise.
v2->v3:
- fix copyright (Alexei);
v1->v2:
- more consistent names for instruction mem size convertion routines (Alexei);
- extended selftests to use relocatable STX instructions (Alexei);
- added a fix for skipping CO-RE relocation for non-loadable programs.
Cc: Luka Perkov <luka.perkov@...tura.hr>
Cc: Tony Ambardar <tony.ambardar@...il.com>
Andrii Nakryiko (4):
libbpf: skip CO-RE relocations for not loaded BPF programs
libbpf: support safe subset of load/store instruction resizing with
CO-RE
libbpf: allow specifying both ELF and raw BTF for CO-RE BTF override
selftests/bpf: validate libbpf's auto-sizing of LD/ST/STX instructions
tools/lib/bpf/libbpf.c | 151 +++++++++++-
.../selftests/bpf/prog_tests/core_autosize.c | 225 ++++++++++++++++++
.../selftests/bpf/progs/test_core_autosize.c | 172 +++++++++++++
3 files changed, 539 insertions(+), 9 deletions(-)
create mode 100644 tools/testing/selftests/bpf/prog_tests/core_autosize.c
create mode 100644 tools/testing/selftests/bpf/progs/test_core_autosize.c
--
2.24.1
Powered by blists - more mailing lists