lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 8 Oct 2020 14:49:27 +0300 From: Vladimir Oltean <olteanv@...il.com> To: Kurt Kanzenbach <kurt@...utronix.de> Cc: Andrew Lunn <andrew@...n.ch>, Vivien Didelot <vivien.didelot@...il.com>, Florian Fainelli <f.fainelli@...il.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org, Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org, Sebastian Andrzej Siewior <bigeasy@...utronix.de>, Richard Cochran <richardcochran@...il.com>, Kamil Alkhouri <kamil.alkhouri@...offenburg.de>, ilias.apalodimas@...aro.org Subject: Re: [PATCH net-next v6 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches On Tue, Oct 06, 2020 at 12:13:04PM +0200, Kurt Kanzenbach wrote: > >> >> +static const struct hellcreek_platform_data de1soc_r1_pdata = { > >> >> + .num_ports = 4, > >> >> + .is_100_mbits = 1, > >> >> + .qbv_support = 1, > >> >> + .qbv_on_cpu_port = 1, > >> > > >> > Why does this matter? > >> > >> Because Qbv on the CPU port is a feature and not all switch variants > >> have that. It will matter as soon as TAPRIO is implemented. > > > > How do you plan to install a tc-taprio qdisc on the CPU port? > > That's an issue to be sorted out. Do you have a compelling use case for tc-taprio on the CPU port though? I've been waiting for someone to put one on the table. If it's just "nice to have", I don't think that DSA will change just to accomodate that. The fact that the CPU port doesn't have a net device is already pretty much the established behavior.
Powered by blists - more mailing lists