netdev - Re: [PATCH net-next v2 3/7] ethtool: trim policy tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c989c579-01b2-3527-bc57-3f88250ca011@gmail.com>
Date:   Thu, 8 Oct 2020 17:09:13 +0200
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Johannes Berg <johannes@...solutions.net>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, kernel-team@...com, jiri@...nulli.us,
        andrew@...n.ch, mkubecek@...e.cz
Subject: Re: [PATCH net-next v2 3/7] ethtool: trim policy tables



On 10/8/20 11:15 AM, Johannes Berg wrote:
> On Thu, 2020-10-08 at 11:13 +0200, Johannes Berg wrote:
> 
>>> This implies that all policy tables must be 'complete'.
> 
> Also, yes they had to be complete already, perhaps *except* for NLA_FLAG
> like this below use ...
> 
>>> So when later strset_parse_request() does :
>>>
>>> req_info->counts_only = tb[ETHTOOL_A_STRSET_COUNTS_ONLY];
>>>
>> Here was the fix
>> https://lore.kernel.org/netdev/20201007125348.a74389e18168.Ieab7a871e27b9698826e75dc9e825e4ddbc852b1@changeid/
> 
> Sorry, wrong link
> 
> https://lore.kernel.org/netdev/20201007125348.a0b250308599.Ie9b429e276d064f28ce12db01fffa430e5c770e0@changeid/
> 
> johannes
> 

SGTM, thanks !