netdev - Re: [net-next PATCH v3] net: dsa: rtl8366rb: Roof MTU for switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201008091437.559e3d6c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 8 Oct 2020 09:14:37 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>
Subject: Re: [net-next PATCH v3] net: dsa: rtl8366rb: Roof MTU for switch

On Thu,  8 Oct 2020 11:19:55 +0200 Linus Walleij wrote:
> diff --git a/drivers/net/dsa/rtl8366rb.c b/drivers/net/dsa/rtl8366rb.c
> index 053bf5041f8d..28f510a580be 100644
> --- a/drivers/net/dsa/rtl8366rb.c
> +++ b/drivers/net/dsa/rtl8366rb.c
> @@ -311,6 +311,13 @@
>  #define RTL8366RB_GREEN_FEATURE_TX	BIT(0)
>  #define RTL8366RB_GREEN_FEATURE_RX	BIT(2)
>  
> +/**
> + * struct rtl8366rb - RTL8366RB-specific data
> + */
> +struct rtl8366rb {
> +	unsigned int max_mtu[RTL8366RB_NUM_PORTS];
> +};

If you make the comment kdoc, you gotta describe all fields (or mark
'em private) otherwise:

drivers/net/dsa/rtl8366rb.c:319: warning: Function parameter or member 'max_mtu' not described in 'rtl8366rb'