netdev - Re: [PATCH net-next] ne2k-pci: Enable RW-Bugfix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201008180108.43e502a7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 8 Oct 2020 18:01:08 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Armin Wolf <W_Armin@....de>
Cc:     davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ne2k-pci: Enable RW-Bugfix

On Tue,  6 Oct 2020 18:56:06 +0200 Armin Wolf wrote:
> Enable the ne2k-pci Read-before-Write Bugfix
> since not doing so could (according to the Datasheet)
> cause the system to lock up with some chips.
> 
> Signed-off-by: Armin Wolf <W_Armin@....de>
> ---
>  drivers/net/ethernet/8390/ne2k-pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/8390/ne2k-pci.c b/drivers/net/ethernet/8390/ne2k-pci.c
> index bc6edb3f1af3..a1319cd86ab9 100644
> --- a/drivers/net/ethernet/8390/ne2k-pci.c
> +++ b/drivers/net/ethernet/8390/ne2k-pci.c
> @@ -91,7 +91,7 @@ MODULE_PARM_DESC(full_duplex, "full duplex setting(s) (1)");
>  #define USE_LONGIO
> 
>  /* Do we implement the read before write bugfix ? */
> -/* #define NE_RW_BUGFIX */
> +#define NE_RW_BUGFIX

This doesn't do anything, does it:

$ git grep NE_RW_BUGFIX
drivers/net/ethernet/8390/ne.c:/* #define NE_RW_BUGFIX */
drivers/net/ethernet/8390/ne2k-pci.c:/* #define NE_RW_BUGFIX */