netdev - Re: [PATCH v3 1/1] net/rds: suppress page allocation failure error in recv buffer refill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201009123416.0ce3ae57@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 9 Oct 2020 12:34:16 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Manjunath Patil <manjunath.b.patil@...cle.com>
Cc:     santosh.shilimkar@...cle.com, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, aruna.ramakrishna@...cle.com,
        rama.nichanamatlu@...cle.com
Subject: Re: [PATCH v3 1/1] net/rds: suppress page allocation failure error
 in recv buffer refill

On Tue,  6 Oct 2020 14:31:37 -0700 Manjunath Patil wrote:
> RDS/IB tries to refill the recv buffer in softirq context using
> GFP_NOWAIT flag. However alloc failure is handled by queueing a work to
> refill the recv buffer with GFP_KERNEL flag. This means failure to
> allocate with GFP_NOWAIT isn't fatal. Do not print the PAF warnings if
> softirq context fails to refill the recv buffer. We will see the PAF
> warnings when worker also fails to allocate.
> 
> Signed-off-by: Manjunath Patil <manjunath.b.patil@...cle.com>
> Reviewed-by: Aruna Ramakrishna <aruna.ramakrishna@...cle.com>

Applied to net-next, thanks!