lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 9 Oct 2020 11:59:10 +0800 From: Jason Wang <jasowang@...hat.com> To: Eugenio Perez Martin <eperezma@...hat.com> Cc: Michael Tsirkin <mst@...hat.com>, Cindy Lu <lulu@...hat.com>, kvm list <kvm@...r.kernel.org>, virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Rob Miller <rob.miller@...adcom.com>, lingshan.zhu@...el.com, Harpreet Singh Anand <hanand@...inx.com>, mhabets@...arflare.com, eli@...lanox.com, Adrian Moreno Zapata <amorenoz@...hat.com>, Maxime Coquelin <maxime.coquelin@...hat.com>, Stefan Hajnoczi <stefanha@...hat.com>, Stefano Garzarella <sgarzare@...hat.com> Subject: Re: [RFC PATCH 18/24] vhost-vdpa: support ASID based IOTLB API On 2020/9/28 下午11:44, Eugenio Perez Martin wrote: >> - u64 iova, u64 size) >> +static int vhost_vdpa_unmap(struct vhost_vdpa *v, >> + struct vhost_iotlb *iotlb, >> + u64 iova, u64 size) >> { >> struct vdpa_device *vdpa = v->vdpa; >> const struct vdpa_config_ops *ops = vdpa->config; >> + u32 asid = (iotlb); >> + >> + if (!iotlb) >> + return -EINVAL; > This should be reorder to check for (!iotlb) before use at `asid = > iotlb_to_asid()`, isn't it? > > Thanks! > Yes, will fix in the next version. Thanks
Powered by blists - more mailing lists