netdev - Re: [PATCH net-next] net: mscc: ocelot: add missing VCAP ES0 and IS1 regmaps for VSC7514

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201008175342.01ea014d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 8 Oct 2020 17:53:42 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     davem@...emloft.net, alexandre.belloni@...tlin.com,
        netdev@...r.kernel.org, UNGLinuxDriver@...rochip.com,
        Divya Koppera <Divya.Koppera@...rochip.com>
Subject: Re: [PATCH net-next] net: mscc: ocelot: add missing VCAP ES0 and
 IS1 regmaps for VSC7514

On Tue,  6 Oct 2020 18:02:48 +0300 Vladimir Oltean wrote:
> Without these definitions, the driver will crash in:
> mscc_ocelot_probe
> -> ocelot_init
>    -> ocelot_vcap_init
>      -> __ocelot_target_read_ix  
> 
> I missed this because I did not have the VSC7514 hardware to test, only
> the VSC9959 and VSC9953, and the probing part is different.
> 
> Fixes: e3aea296d86f ("net: mscc: ocelot: add definitions for VCAP ES0 keys, actions and target")
> Fixes: a61e365d7c18 ("net: mscc: ocelot: add definitions for VCAP IS1 keys, actions and target")
> Reported-by: Divya Koppera <Divya.Koppera@...rochip.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Applied, thanks!