netdev - Re: [PATCH] dpaa_eth: enable NETIF_MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 10 Oct 2020 10:51:00 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Madalin Bucur (OSS)" <madalin.bucur@....nxp.com>
Cc:     Vladimir Oltean <vladimir.oltean@....com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Camelia Alexandra Groza <camelia.groza@....com>,
        Maxim Kochetkov <fido_max@...ox.ru>
Subject: Re: [PATCH] dpaa_eth: enable NETIF_MSG_HW by default

On Thu, 8 Oct 2020 14:37:44 +0000 Madalin Bucur (OSS) wrote:
> > From: Maxim Kochetkov <fido_max@...ox.ru>
> > 
> > When packets are received on the error queue, this function under
> > net_ratelimit():
> > 
> > netif_err(priv, hw, net_dev, "Err FD status = 0x%08x\n");
> > 
> > does not get printed. Instead we only see:
> > 
> > [ 3658.845592] net_ratelimit: 244 callbacks suppressed
> > [ 3663.969535] net_ratelimit: 230 callbacks suppressed
> > [ 3669.085478] net_ratelimit: 228 callbacks suppressed
> > 
> > Enabling NETIF_MSG_HW fixes this issue, and we can see some information
> > about the frame descriptors of packets.
> > 
> > Signed-off-by: Maxim Kochetkov <fido_max@...ox.ru>
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>
> 
> Reviewed-by: Madalin Bucur <madalin.bucur@....nxp.com>

Applied, thanks everyone!