lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 9 Oct 2020 20:43:09 -0400
From:   Willem de Bruijn <>
To:     Deepa Dinamani <>
Cc:     Christian Eggers <>,
        "David S . Miller" <>,
        Jakub Kicinski <>,
        Christoph Hellwig <>,
        Linux Network Devel Mailing List <>,
        Linux Kernel Mailing List <>,
        Arnd Bergmann <>
Subject: Re: [PATCH net 1/2] socket: fix option SO_TIMESTAMPING_NEW

On Fri, Oct 9, 2020 at 8:30 PM Deepa Dinamani <> wrote:
> On Fri, Oct 9, 2020 at 3:32 AM Christian Eggers <> wrote:
> >
> > The comparison of optname with SO_TIMESTAMPING_NEW is wrong way around,
> > so SOCK_TSTAMP_NEW will first be set and than reset again. Additionally
> > move it out of the test for SOF_TIMESTAMPING_RX_SOFTWARE as this seems
> > unrelated.
> The SOCK_TSTAMP_NEW is reset only in the case when
> Note that we only call sock_enable_timestamp() at that time.
> Why would SOCK_TSTAMP_NEW be relevant otherwise?

Other timestamps can be configured, such as hardware timestamps.

As the follow-on patch shows, there is also the issue of overlap

Don't select OLD on timestamp disable, which may only disable
some of the ongoing timestamping.

Setting based on the syscall is simpler, too. __sock_set_timestamps
already uses for SO_TIMESTAMP(NS) the valbool approach I
suggest for SO_TIMESTAMPING.

The fallthrough can also be removed. My rough patch missed that.

Powered by blists - more mailing lists