lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 10 Oct 2020 17:01:26 +0900 From: Benjamin Poirier <benjamin.poirier@...il.com> To: Coiby Xu <coiby.xu@...il.com> Cc: devel@...verdev.osuosl.org, Shung-Hsi Yu <shung-hsi.yu@...e.com>, Manish Chopra <manishc@...vell.com>, "supporter:QLOGIC QLGE 10Gb ETHERNET DRIVER" <GR-Linux-NIC-Dev@...vell.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "open list:QLOGIC QLGE 10Gb ETHERNET DRIVER" <netdev@...r.kernel.org>, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v1 5/6] staging: qlge: clean up debugging code in the QL_ALL_DUMP ifdef land On 2020-10-08 19:58 +0800, Coiby Xu wrote: > The debugging code in the following ifdef land > - QL_ALL_DUMP > - QL_REG_DUMP > - QL_DEV_DUMP > - QL_CB_DUMP > - QL_IB_DUMP > - QL_OB_DUMP > > becomes unnecessary because, > - Device status and general registers can be obtained by ethtool. > - Coredump can be done via devlink health reporter. > - Structure related to the hardware (struct ql_adapter) can be obtained > by crash or drgn. > > Suggested-by: Benjamin Poirier <benjamin.poirier@...il.com> > Signed-off-by: Coiby Xu <coiby.xu@...il.com> > --- > drivers/staging/qlge/qlge.h | 82 ---- > drivers/staging/qlge/qlge_dbg.c | 688 ---------------------------- > drivers/staging/qlge/qlge_ethtool.c | 2 - > drivers/staging/qlge/qlge_main.c | 7 +- Please also update drivers/staging/qlge/TODO accordingly. There is still a lot of debugging code IMO (the netif_printk statements - kernel tracing can be used instead of those) but this patch is a substantial improvement.
Powered by blists - more mailing lists