netdev - Re: [net-next PATCH v4] net: dsa: rtl8366rb: Roof MTU for switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20201010113602.49e63312@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Sat, 10 Oct 2020 11:36:02 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>
Subject: Re: [net-next PATCH v4] net: dsa: rtl8366rb: Roof MTU for switch

On Thu, 8 Oct 2020 14:09:13 -0700 Florian Fainelli wrote:
> On 10/8/2020 2:03 PM, Linus Walleij wrote:
> > The MTU setting for this DSA switch is global so we need
> > to keep track of the MTU set for each port, then as soon
> > as any MTU changes, roof the MTU to the biggest common
> > denominator and poke that into the switch MTU setting.
> > 
> > To achieve this we need a per-chip-variant state container
> > for the RTL8366RB to use for the RTL8366RB-specific
> > stuff. Other SMI switches does seem to have per-port
> > MTU setting capabilities.
> > 
> > Fixes: 5f4a8ef384db ("net: dsa: rtl8366rb: Support setting MTU")
> > Signed-off-by: Linus Walleij <linus.walleij@...aro.org>  
> 
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

Applied, thanks!